Receipt · 83e79770-2
Composite endpoint returns success status (200) on internal failure, misleading clients
api-contractmedium
repo d2246a0e·PR #1·reviewed 13 hours ago
The finding
- app/api/composite/route.ts:50-62
On any failure (including download failures earlier in the function which return 400 with `error` and no `s3Url`, vs the catch which returns 200 with `error` and no `s3Url`) the route claims success with HTTP 200 but does not return an `s3Url`. The comment says "returning base video" but the base video URL is not in the response, so a client following the contract will get `undefined.s3Url`. This is a deceptive comment and a broken contract.
Fix
Either include the original `videoUrl` in the 200 response as a fallback (matching the comment) or return a proper 5xx so clients can branch. Decide on one contract and update the comment.
Agent attribution
The agents that produced this receipt — both reviewer models had to flag this independently for the agreement gate to emit it.
anthropic
gpt-5
92.0s · error
openai
claude-opus-4-7
136.5s · error
Total
wall-clock review time · est. inference cost
136.5s · $0.40
Sweeper
closed at SHA
still open
internal review id · 83e79770
Third-party witnesses
Everything below lives on GitHub's event log, not ours. Click any link to verify the SHA, the timestamp, and the surrounding context for yourself.
Original review comment
https://github.com/Augustas11/krisskross_shops/pull/1#issuecomment-4467353797