Anatomy · eba8958d-1

InstallDialog re-fetches server detail when prefillEnv changes, causing unnecessary network calls

lowmaintainability

repo df3ede3f·PR #2·reviewed 1 week ago

The vulnerable code

app/src/components/channels/mcp/InstallDialog.tsx:0-0

Code snippet unavailable.

The reasoning

Opus

Output unavailable for this row.

GPT-5

InstallDialog re-fetches server detail when prefillEnv changes, causing unnecessary network calls

lowmaintainabilityhigh

app/src/components/channels/mcp/InstallDialog.tsx

Including prefillEnv in the dependency array triggers a fresh registryGet whenever the suggested env values change, even though the server detail itself has not changed. This wastes network calls and risks brief UI flicker; only envValues need updating when prefillEnv changes.

Recommendation

Remove prefillEnv from the effect dependencies. Add a separate effect that, when detail is loaded and prefillEnv changes, updates envValues for the known keys without re-fetching detail.

The agreement

Both frontier models flagged this within the same line range. AntFleet's unanimous gate fired — the finding posted on the PR.

Closure

Tweet thread template

tweet 1 of 8188 / 280

Two frontier models reviewed PR #2 on df3ede3f. Both found this bug: low maintainability: InstallDialog re-fetches server detail when prefillEnv changes, causing unnecessary network calls

tweet 2 of 8139 / 280

The vulnerable code (app/src/components/channels/mcp/InstallDialog.tsx:0-0): (full snippet at https://www.antfleet.dev/anatomy/eba8958d-1)

tweet 3 of 836 / 280

What Opus saw: "Output unavailable"

tweet 4 of 8280 / 280

What GPT-5 saw: "Including prefillEnv in the dependency array triggers a fresh registryGet whenever the suggested env values change, even though the server detail itself has not changed. This wastes network calls and risks brief UI flicker; only envValues need updating when pre…

tweet 5 of 897 / 280

Both flagged the same line range. AntFleet's unanimous gate fired — the finding posted on the PR.

tweet 6 of 893 / 280

The fix landed in commit pending: (view diff at https://www.antfleet.dev/anatomy/eba8958d-1)

tweet 7 of 881 / 280

AntFleet reviews every PR with two frontier models. Only unanimous findings post.

tweet 8 of 877 / 280

Full anatomy + reasoning + diffs: https://www.antfleet.dev/anatomy/eba8958d-1

Paste into X composer one tweet at a time. X has no multi-tweet intent API.

view receipt →all receipts →view disagreements →case studies →