Receipt · eba8958d-1
InstallDialog re-fetches server detail when prefillEnv changes, causing unnecessary network calls
maintainabilitylow
repo df3ede3f·PR #2·reviewed 1 week ago
The finding
- app/src/components/channels/mcp/InstallDialog.tsx
Including prefillEnv in the dependency array triggers a fresh registryGet whenever the suggested env values change, even though the server detail itself has not changed. This wastes network calls and risks brief UI flicker; only envValues need updating when prefillEnv changes.
Fix
Remove prefillEnv from the effect dependencies. Add a separate effect that, when detail is loaded and prefillEnv changes, updates envValues for the known keys without re-fetching detail.
Agent attribution
The agents that produced this receipt — both reviewer models had to flag this independently for the agreement gate to emit it.
anthropic
gpt-5
66.5s · error
openai
claude-opus-4-7
149.2s · error
Total
wall-clock review time · est. inference cost
149.2s · $0.40
Sweeper
closed at SHA
still open
internal review id · eba8958d
Third-party witnesses
Everything below lives on GitHub's event log, not ours. Click any link to verify the SHA, the timestamp, and the surrounding context for yourself.
Original review comment
https://github.com/AntFleet/agent-openhuman-bench/pull/2#issuecomment-4494700328