AntFleet

Disagreement · eba8958d-anthropic-3

ChannelSelector indexes CHANNEL_ICONS by def.icon for real channels but by tab.id for virtual tabs (inconsistent and likely wrong)

solo Opus
repo df3ede3f·PR #2·reviewed 1 week ago

Opus finding

ChannelSelector indexes CHANNEL_ICONS by def.icon for real channels but by tab.id for virtual tabs (inconsistent and likely wrong)

lowbugmedium
  • app/src/components/channels/ChannelSelector.tsx:16-23
  • app/src/components/channels/ChannelSelector.tsx:86-88
  • app/src/components/channels/ChannelSelector.tsx:105-107
The CHANNEL_ICONS map keys are channel ids (telegram/discord/web/mcp). For real channels the code looks up by `def.icon` (an icon name from the definition), not by the channel id. If `def.icon` happens to differ from the id (e.g., 'telegram-plane', 'paper-plane', or empty), the icon silently falls back to '' rather than rendering. Meanwhile, virtual tabs look up by `tab.id`. The two paths use different key spaces against the same map, suggesting either the comment/map is wrong or the real-channel path should use `def.id`.

Recommendation

Decide on a single key — either store icon emojis keyed by `def.icon` (and ensure backend uses those keys) or index by channel id consistently. Add a fallback emoji.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.

← back to all disagreementsview public receiptssee unanimous findings + anatomies →
Tweet ↗