AntFleet

Disagreement · eba8958d-anthropic-4

InstallDialog Enter-to-submit gap: no keyboard submit handler in the install form

solo Opus
repo df3ede3f·PR #2·reviewed 1 week ago

Opus finding

InstallDialog Enter-to-submit gap: no keyboard submit handler in the install form

lowmaintainabilitymedium
  • app/src/components/channels/mcp/InstallDialog.tsx:165-215
The dialog uses a <div> container with <input>/<textarea> rather than a <form>. Users typically expect Enter in a single-line input to submit. The install button is the only submit affordance. Combined with `type="password"` inputs that browsers normally treat as submit-on-Enter inside a form, the UX may be surprising. Not a correctness bug but a maintainability/UX concern worth noting since other components in this slice (ConfigAssistantPanel) explicitly add keyboard handlers.

Recommendation

Wrap inputs in a <form> with onSubmit={handleInstall} and use type="submit" for the Install button, or add an onKeyDown handler to env inputs.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.

← back to all disagreementsview public receiptssee unanimous findings + anatomies →
Tweet ↗