AntFleet

Disagreement · eba8958d-openai-1

Debounced search keeps stale results visible and may paginate wrong page after query change

solo GPT-5
repo df3ede3f·PR #2·reviewed 1 week ago

GPT-5 finding

Debounced search keeps stale results visible and may paginate wrong page after query change

lowmaintainabilityhigh
  • app/src/components/channels/mcp/McpCatalogBrowser.tsx
  • app/src/components/channels/mcp/McpCatalogBrowser.tsx
When query changes, the component triggers a debounced fetch but does not clear servers or reset page until the response arrives. During that window, prior results and a Load more button may remain, allowing the user to request page+1 for the new query using an outdated page value, mixing results. This is a subtle correctness/UX issue that complicates state reasoning.

Recommendation

On query change, immediately clear servers and reset page/totalPages (e.g., setServers([]); setPage(1); setTotalPages(1)) and hide Load more until the first response for the new query arrives. Optionally, track a requestId to ignore late responses from prior queries.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.

← back to all disagreementsview public receiptssee unanimous findings + anatomies →
Tweet ↗