AntFleet

Disagreement · eba8958d-openai-3

InstallDialog re-fetches server detail when prefillEnv changes, causing unnecessary network calls

solo GPT-5
repo df3ede3f·PR #2·reviewed 1 week ago

GPT-5 finding

InstallDialog re-fetches server detail when prefillEnv changes, causing unnecessary network calls

lowmaintainabilityhigh
  • app/src/components/channels/mcp/InstallDialog.tsx
Including prefillEnv in the dependency array triggers a fresh registryGet whenever the suggested env values change, even though the server detail itself has not changed. This wastes network calls and risks brief UI flicker; only envValues need updating when prefillEnv changes.

Recommendation

Remove prefillEnv from the effect dependencies. Add a separate effect that, when detail is loaded and prefillEnv changes, updates envValues for the known keys without re-fetching detail.

Other reviewer

The other reviewer flagged nothing in this file/line range.

Why this didn't post

This finding didn't meet AntFleet's unanimous agreement threshold. Both frontier models review every PR independently; only findings they both flag with the same severity and category are posted to the PR. This one fell through.

read the methodology →

From the same review

These findings passed the unanimous gate on the same PR review. The disagreement above was filtered out; the findings below were posted.

← back to all disagreementsview public receiptssee unanimous findings + anatomies →
Tweet ↗